fix(editor): stop the query editor stealing focus on tab open; add VoiceOver labels (#1490)#1507
Merged
Conversation
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1490 (keyboard, focus, accessibility). Query editor surface.
Focus
firstResponder == nilor the window itself), so opening a query tab while the sidebar or another control is focused no longer yanks focus into the editor. Builds on theisDestroyedguard from fix(datagrid): move focus to grid on explicit table open (#1490) #1497.VoiceOver
SourceEditorgets.accessibilityLabel("SQL query editor").Native APIs only. Several other gaps from the audit are already merged (filter-apply focus return in #1492) or are larger follow-ups (Tab-to-exit the editor via the key view loop, the first-responder polling refactor, the split key-view-loop wiring).
Lint clean, style gate clean. Focus/VoiceOver verified manually.